-
Notifications
You must be signed in to change notification settings - Fork 929
Firestore lite overview #4861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firestore lite overview #4861
Conversation
|
Binary Size ReportAffected SDKs
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with rewrite suggestion :)
packages/firestore/lite/index.ts
Outdated
* Firestore Lite | ||
* | ||
* @remarks This package includes the same feature set as Firestore, but | ||
* without latency compensation or snapshot listeners (and with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do users know what these features are? What about something like this:
Firestore Lite is a small online-only SDK that allows read and write access to your Firestore database. All operations talk directly to the backend and onSnapshot()
APIs are not supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds great! And . . . can you send a PR that adds it Sebastian?
I'm discouraged by the failing tests I see for this PR, as well as my ongoing inability to create a clean client (why do I seem to have 12 commits on a brand-new branch for which git status was clear?).
Quickest way forward that I can see is for me to drop this PR and for you or Fei to add the FL description. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can certainly take this to completion. Do you have rewording suggestions or should we take my suggestion as is? I would be disappointed if you didn't have an improvement in the back of your head :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hehe, all I got is a comma and a substitution for "talk to," which the style guide says to avoid. How about:
"Firestore Lite is a small online-only SDK that allows read and write access to your Firestore database. All operations connect directly to the backend, and onSnapshot()
APIs are not supported."
I tried re-running the CI jobs on Feiyang's advice, but it looks like I still have several tests failing. If you could take this Sebastian, that would be awesome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed directly to this PR. Fingers crossed.
This can now be merged pending the lift of the code freeze |
Adding a simple overview to explain what Firestore Lite is.
Later if we have richer/more detailed information in the guides, we can link to that as well.